Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 )
Change subject: generic_iterators: basic MergeIterator dominance ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/12197/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12197/4//COMMIT_MSG@25 PS4, Line 25: MergeIterator histogram for all four runs. > per some comment earlier in the patch series, I'd be more interested in kno I've replaced this with the average number of comparisons performed and microbenchmark running time. If you want raw perf stat output I can show that too; it's just quite verbose given the four different runs so I didn't want to include it in the commit message. -- To view, visit http://gerrit.cloudera.org:8080/12197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If59d831240af15bfa7ef5709ec3d105d13b28322 Gerrit-Change-Number: 12197 Gerrit-PatchSet: 4 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 11 Jan 2019 23:53:54 +0000 Gerrit-HasComments: Yes
