Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12197 )
Change subject: generic_iterators: basic MergeIterator dominance ...................................................................... Patch Set 7: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@102 PS7, Line 102: <> I think you can remove the need for dispose, etc in the implementation by specifying : public list_base_hook<void_pointer<std::unique_ptr<void>>> Have you tried something like that? Per https://www.boost.org/doc/libs/1_69_0/doc/html/intrusive/using_smart_pointers.html I am not 100% sure about this, though, and maybe it's less relevant if we are using disposal lambdas to move elements between lists. http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@104 PS7, Line 104: NOLINT(*) Just curious: why is NOLINT necessary? How about a "using" alias declaration instead, if that prevents the lint warning? http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@274 PS7, Line 274: underflowing nit: overflow in the negative direction is still overflow as opposed to insufficient precision http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@333 PS7, Line 333: domination makes me think of https://www.youtube.com/watch?v=lYPFrXvc2rE&t=2m34s ?? http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@459 PS7, Line 459: restart_inner_loop: nit: indentation here appears to be 3 spaces and I assume you meant it to be 0 or 6 spaces? http://gerrit.cloudera.org:8080/#/c/12197/7/src/kudu/common/generic_iterators.cc@608 PS7, Line 608: bounds are lower bound is? -- To view, visit http://gerrit.cloudera.org:8080/12197 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If59d831240af15bfa7ef5709ec3d105d13b28322 Gerrit-Change-Number: 12197 Gerrit-PatchSet: 7 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 24 Jan 2019 08:56:52 +0000 Gerrit-HasComments: Yes
