Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12240 )
Change subject: KUDU-2456 Limit number of pending transactions logged ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12240/3/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/12240/3/src/kudu/tablet/transactions/transaction_tracker.cc@209 PS3, Line 209: const nit: constexpr ? http://gerrit.cloudera.org:8080/#/c/12240/3/src/kudu/tablet/transactions/transaction_tracker.cc@235 PS3, Line 235: int nit: use 'auto' instead of 'int' here (and automatically don't bother about implicitly converting size_t to int)? http://gerrit.cloudera.org:8080/#/c/12240/3/src/kudu/tablet/transactions/transaction_tracker.cc@236 PS3, Line 236: int nit: auto? -- To view, visit http://gerrit.cloudera.org:8080/12240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626adfea269a15b5cadd13876c940ba5bfdcfb03 Gerrit-Change-Number: 12240 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 19 Jan 2019 00:46:56 +0000 Gerrit-HasComments: Yes
