Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12240 )
Change subject: KUDU-2456 Limit number of pending transactions logged ...................................................................... Patch Set 3: (3 comments) Didn't realize I need to explicitly reply for comments marked as done. http://gerrit.cloudera.org:8080/#/c/12240/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12240/2//COMMIT_MSG@14 PS2, Line 14: Change-Id: I626adfea269a15b5cadd13876c940ba5bfdcfb03 : > Since it's just a logging change, I don't think you need to explicitly unit Done http://gerrit.cloudera.org:8080/#/c/12240/1/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/12240/1/src/kudu/tablet/transactions/transaction_tracker.cc@232 PS1, Line 232: lete > nit: missing space? Done http://gerrit.cloudera.org:8080/#/c/12240/2/src/kudu/tablet/transactions/transaction_tracker.cc File src/kudu/tablet/transactions/transaction_tracker.cc: http://gerrit.cloudera.org:8080/#/c/12240/2/src/kudu/tablet/transactions/transaction_tracker.cc@210 PS2, Line 210: int wait_time_us = 250; > Style nit: define static constants before regular variables. Done -- To view, visit http://gerrit.cloudera.org:8080/12240 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I626adfea269a15b5cadd13876c940ba5bfdcfb03 Gerrit-Change-Number: 12240 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 20 Jan 2019 19:47:38 +0000 Gerrit-HasComments: Yes
