Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 )
Change subject: [docker] Add an initial docker build ...................................................................... Patch Set 7: Code-Review+1 (14 comments) SGTM, just a few nits http://gerrit.cloudera.org:8080/#/c/12173/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12173/7//COMMIT_MSG@10 PS7, Line 10: various Docker : images Does it make sense to add more specifics about the currently supported platforms in here? http://gerrit.cloudera.org:8080/#/c/12173/7//COMMIT_MSG@14 PS7, Line 14: wih with? http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@31 PS7, Line 31: seperate separate http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@31 PS7, Line 31: TODO We don't have a style guide for Dockerfiles, but maybe follow the same style for TODO that we have in C++ source files? I.e., TODO --> TODO(ghenke) http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@51 PS7, Line 51: nit: maybe, add an extra indent for this line since it's a continuation of a sub-element in the former one. http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@63 PS7, Line 63: it's its http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@79 PS7, Line 79: /* nit: drop ? Or you want to keep subdirs like .x ? http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@84 PS7, Line 84: /* ditto http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@114 PS7, Line 114: TODO nit: TODO(ghenke) http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@116 PS7, Line 116: ARG PARALLEL=4 Maybe, just rely on GNU make and run as many parallel tasks as it allows by dependency tree? http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@138 PS7, Line 138: -j${PARALLEL} As commented above, maybe just leave '-j' and run as many parallel tasks as the target dependency tree allows? http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@250 PS7, Line 250: TODO nit: TODO(ghenke) http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@288 PS7, Line 288: TODO nit: TODO(ghenke) http://gerrit.cloudera.org:8080/#/c/12173/6/docker/bootstrap-env.sh File docker/bootstrap-env.sh: http://gerrit.cloudera.org:8080/#/c/12173/6/docker/bootstrap-env.sh@165 PS6, Line 165: "Unsupported OS" > There are no official SLES images in docker hub. There is OpenSUSE that we SGTM -- To view, visit http://gerrit.cloudera.org:8080/12173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95497b39e47f07301be75cbadd814656c7e2ea42 Gerrit-Change-Number: 12173 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jan 2019 20:18:01 +0000 Gerrit-HasComments: Yes
