Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12173 )
Change subject: [docker] Add an initial docker build ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/12173/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12173/7//COMMIT_MSG@10 PS7, Line 10: various Docker : images > It's in the code and "supported" isn't really a thing yet anyway given this OK http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@31 PS7, Line 31: TODO > I actually really dislike the TODO(user) model. Given this is an open sourc Sometimes annotate/blame can be not very straightforward when the code moves around (file renaming, moving just code around). If you don't like that TODO(user), that's totally fine with me. http://gerrit.cloudera.org:8080/#/c/12173/7/docker/Dockerfile@79 PS7, Line 79: /* > Not sure what you mean. This isn't leaving any subdirectories other than th The example is below: dhcp-10-16-3-47:tmp$ find /tmp/m /tmp/m /tmp/m/.x /tmp/m/a /tmp/m/x dhcp-10-16-3-47:tmp$ find /tmp/m/* /tmp/m/a /tmp/m/x So, my question is: do you need that '*' globing to keep directories like '.x' (if any exist)? If not, then I suggest to drop that useless '*' globing. -- To view, visit http://gerrit.cloudera.org:8080/12173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I95497b39e47f07301be75cbadd814656c7e2ea42 Gerrit-Change-Number: 12173 Gerrit-PatchSet: 7 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 25 Jan 2019 21:59:32 +0000 Gerrit-HasComments: Yes
