Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12184 )

Change subject: rpc: add TCP socket statistics to /rpcz
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc
File src/kudu/rpc/connection.cc:

http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@968
PS1, Line 968:
> nit: ditto
Done


http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@970
PS1, Line 970:
> ditto
Done


http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h
File src/kudu/rpc/reactor.h:

http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/reactor.h@152
PS1, Line 152: DumpRunningRpcs
> should probably rename this and related calls
Done



--
To view, visit http://gerrit.cloudera.org:8080/12184
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2
Gerrit-Change-Number: 12184
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Comment-Date: Mon, 28 Jan 2019 04:00:20 +0000
Gerrit-HasComments: Yes

Reply via email to