Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12184 )
Change subject: rpc: add TCP socket statistics to /rpcz ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.cc: http://gerrit.cloudera.org:8080/#/c/12184/1/src/kudu/rpc/connection.cc@959 PS1, Line 959: > nit: are these tabs? If yes, replace with spaces. huh, perils of flipping between different editors on different machines I guess. I'm surprised lint didn't complain -- To view, visit http://gerrit.cloudera.org:8080/12184 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I552c9dd80c0730ccd6bf7b13bb63761744a854c2 Gerrit-Change-Number: 12184 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 09 Jan 2019 20:52:19 +0000 Gerrit-HasComments: Yes
