Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 )
Change subject: [tools] Add table scan tool ...................................................................... Patch Set 15: (2 comments) One small thing and it's good to go! Thanks. This is a useful tool. Looking forward, I think we eventually might want to specialize this tool into two different tools: a `kudu perf table_scan` tool that is meant to measure performance, and a `kudu table scan` tool that is meant to be used to see a few rows from a table or find specific rows. You plan to use the tool for the former, whereas I expect to use it more for the latter. Right now both use cases can be done with the right combination of flags. In the future, it might be nice to wrap the same code with different defaults to cover the two use cases. Not needed for this patch though. http://gerrit.cloudera.org:8080/#/c/12167/10/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: http://gerrit.cloudera.org:8080/#/c/12167/10/src/kudu/client/scanner-internal.h@314 PS10, Line 314: if (direct_data_.empty()) { : return KuduRowResult(projection_, nullptr); : } > Yes, it's a bug fix, some new added unit test will be failed. While project Gotcha. http://gerrit.cloudera.org:8080/#/c/12167/15/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12167/15/src/kudu/tools/tool_action_table.cc@469 PS15, Line 469: Scan rows from an exist table, several predicates can specified Howabout: "Scan rows from an existing table. See the help for the --predicates flag on how predicates can be specified." -- To view, visit http://gerrit.cloudera.org:8080/12167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac340b70a9eaf131f82a2b7d61336211d1d48f8 Gerrit-Change-Number: 12167 Gerrit-PatchSet: 15 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 28 Jan 2019 19:52:32 +0000 Gerrit-HasComments: Yes
