Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/12167 )
Change subject: [tools] Add table scan tool ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/12167/10/src/kudu/client/scanner-internal.h File src/kudu/client/scanner-internal.h: http://gerrit.cloudera.org:8080/#/c/12167/10/src/kudu/client/scanner-internal.h@314 PS10, Line 314: if (direct_data_.empty()) { : return KuduRowResult(projection_, nullptr); : } > Is this change related to the tool? What's its purpose? Yes, it's a bug fix, some new added unit test will be failed. While projection_ is an empty schema, the direct_data_ be empty too, then we try to construct a KuduRowResult object with direct_data_[offset], it will encounter an invalid address access by direct_data_[0] http://gerrit.cloudera.org:8080/#/c/12167/4/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/12167/4/src/kudu/tools/tool_action_table.cc@18 PS4, Line 18: #include <algorithm > Prefer #include <cstdlib>. Done -- To view, visit http://gerrit.cloudera.org:8080/12167 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieac340b70a9eaf131f82a2b7d61336211d1d48f8 Gerrit-Change-Number: 12167 Gerrit-PatchSet: 10 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 25 Jan 2019 13:21:18 +0000 Gerrit-HasComments: Yes
