Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 )
Change subject: [thirdparty] detection of broken std::regex in libstdc++ ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12302/1/build-support/lint.sh File build-support/lint.sh: http://gerrit.cloudera.org:8080/#/c/12302/1/build-support/lint.sh@51 PS1, Line 51: if [[ "$OSTYPE" =~ ^linux ]]; then : distro=$(lsb_release --short --id) : release=$(lsb_release --short --release) : if ([[ $distro == "Ubuntu" ]] && [[ $release =~ 14\.[[:digit:]]+ ]]) || \ : ([[ $distro =~ (CentOS|RedHatEnterpriseServer) ]] && [[ $release =~ 7\.[[:digit:]]+ ]]) || \ : ([[ $distro =~ "SUSE" ]] && [[ $release =~ 12(\.[[:digit:]]+)? ]]); then : filter="+runtime/broken_libstdcpp_regex,${filter}" : fi : fi : Why condition this at all? As long as Kudu needs to support these older platforms, std::regex should be forbidden, regardless of what machine you happen to be running on. http://gerrit.cloudera.org:8080/#/c/12302/1/thirdparty/patches/google-styleguide-cpplint.patch File thirdparty/patches/google-styleguide-cpplint.patch: PS1: You wrote this patch, right? Would it be possible to add comments or something to it to provide context? -- To view, visit http://gerrit.cloudera.org:8080/12302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7d01c536a3e2c059c9c9f6a8d14dcb6d6acad1 Gerrit-Change-Number: 12302 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 30 Jan 2019 18:08:54 +0000 Gerrit-HasComments: Yes
