Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12302 )
Change subject: [thirdparty] detection of broken std::regex in libstdc++ ...................................................................... Patch Set 3: (2 comments) Thank you for fast review! http://gerrit.cloudera.org:8080/#/c/12302/3/thirdparty/patches/google-styleguide-cpplint.patch File thirdparty/patches/google-styleguide-cpplint.patch: PS3: > You should consider submitting this new functionality as a PR upstream. OK, that makes sense. I'll separate that and try to submit as PR upstream this week or so. http://gerrit.cloudera.org:8080/#/c/12302/3/thirdparty/patches/google-styleguide-cpplint.patch@116 PS3, Line 116: - ('<utility>', ('pair',)), : + ('<utility>', ('pair', 'swap',)), : ('<vector>', ('vector',)), : : # gcc extensions. : @@ -5501,8 +5587,7 @@ : _RE_PATTERN_STRING = re.compile(r'\bstring\b') : : _re_pattern_algorithm_header = [] : -for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'swap', : - 'transform'): : +for _template in ('copy', 'max', 'min', 'min_element', 'sort', 'transform'): > Are these changes related to the broken std::regex check? Nope, those are old changes related to std::swap being migrated from <algorithm> to <util> or something like that in newer C++ toolchains. I added the changes for std::regex into the same patch because that's about patching the same cpplint.py file. -- To view, visit http://gerrit.cloudera.org:8080/12302 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb7d01c536a3e2c059c9c9f6a8d14dcb6d6acad1 Gerrit-Change-Number: 12302 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 31 Jan 2019 00:11:20 +0000 Gerrit-HasComments: Yes
