Hello Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12320
to review the following change.
Change subject: KUDU-2684: deduplicate master addrs on tservers
......................................................................
KUDU-2684: deduplicate master addrs on tservers
This patch deduplicates master addresses that get used to spin up
heartbeater threads. Previously, duplicate addresses meant sending
multiple tablet reports at a time during heartbeats.
This is addressed by having the TabletServer deduplicate the host-port
pairs and passing the deduplicated set to the Heartbeater. I considered
having the TabletServerOptions deduplicate the pairs up front by storing
a set, but that seemed like a wider-touching change, and is at odds with
how we handle user-provided options elsewhere.
Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
---
M src/kudu/integration-tests/ts_tablet_manager-itest.cc
M src/kudu/tserver/heartbeater.cc
M src/kudu/tserver/heartbeater.h
M src/kudu/tserver/tablet_server.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/util/net/net_util.h
6 files changed, 72 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/12320/1
--
To view, visit http://gerrit.cloudera.org:8080/12320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1
Gerrit-Change-Number: 12320
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
