Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12320 )
Change subject: KUDU-2684: deduplicate master addrs on tservers ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc File src/kudu/integration-tests/ts_tablet_manager-itest.cc: http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/integration-tests/ts_tablet_manager-itest.cc@554 PS1, Line 554: The duplication should be considered Nit: not really sure what this is trying to say. http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc File src/kudu/tserver/tablet_server.cc: http://gerrit.cloudera.org:8080/#/c/12320/1/src/kudu/tserver/tablet_server.cc@97 PS1, Line 97: std::vector<HostPort> addr_list; Add a using. -- To view, visit http://gerrit.cloudera.org:8080/12320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c9806cd0a0c1d6bb2fd34a9c74aca84d59756a1 Gerrit-Change-Number: 12320 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 00:16:17 +0000 Gerrit-HasComments: Yes
