Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml File examples/java/java-example/pom.xml: http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/pom.xml@85 PS1, Line 85: > I think we need to add junit as a test dependency such as: I added version 4.12 since that is what the kudu-test-utils project uses. http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java File examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java: PS1: > This file has to live in examples/java/java-example/src/test/java/org/apach Yikes. Good catch. http://gerrit.cloudera.org:8080/#/c/12318/1/examples/java/java-example/src/main/test/org/apache/kudu/examples/ITExample.java@10 PS1, Line 10: > rename to ExampleTest so Maven Surefire will execute the test when we call Done -- To view, visit http://gerrit.cloudera.org:8080/12318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d Gerrit-Change-Number: 12318 Gerrit-PatchSet: 2 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 15:27:11 +0000 Gerrit-HasComments: Yes
