Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12318 )
Change subject: KUDU-2411: Example integration test using KuduMiniCluster ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java File examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java: PS3: Need a license header here. http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@14 PS3, Line 14: Nit: got one extra line too many here. http://gerrit.cloudera.org:8080/#/c/12318/3/examples/java/java-example/src/test/java/org/apache/kudu/examples/ExampleTest.java@17 PS3, Line 17: public void testCreateExampleTable() throws KuduException { Don't you want to use the other functions you made available from the example? To do some inserting and scanning? -- To view, visit http://gerrit.cloudera.org:8080/12318 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ife9103557b30b4105ef57ed36a34f3c93ba2dc6d Gerrit-Change-Number: 12318 Gerrit-PatchSet: 3 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Fri, 01 Feb 2019 19:28:23 +0000 Gerrit-HasComments: Yes
