Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12324 )
Change subject: [tools] KUDU-2557 fix flake in TwoConcurrentRebalancers test ...................................................................... Patch Set 2: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/12324/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12324/2//COMMIT_MSG@28 PS2, Line 28: With that, when the rebalancer observes a tablet's : configuration with more voter replicas than the tablet's target : replication factor, it schedules an operation to remove the source : replica, which is perfectly aligned with the nature of the greedy : rebalancing algorithm. To check my understanding: normally, in 3-4-3, the master would remove a replica marked replace. But because the leader is marked as replace, the tool has to do it? http://gerrit.cloudera.org:8080/#/c/12324/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12324/2/src/kudu/tools/kudu-tool-test.cc@397 PS2, Line 397: <int64_t> What's the purpose of this? -- To view, visit http://gerrit.cloudera.org:8080/12324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5e28f4b644b1549549f50a322c1d7ef376122d3 Gerrit-Change-Number: 12324 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 18:38:18 +0000 Gerrit-HasComments: Yes
