Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12324 )
Change subject: [tools] KUDU-2557 fix flake in TwoConcurrentRebalancers test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12324/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/12324/2/src/kudu/tools/kudu-tool-test.cc@397 PS2, Line 397: <int64_t> > Ah, for some reason the original version failed to compile on my laptop. N Yep, just confirmed that without that change the compilation fails. Basically, the issue comes from using 'long' for 0 ('0L' (using 'long long', i.e. '0LL' would help as well). -- To view, visit http://gerrit.cloudera.org:8080/12324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5e28f4b644b1549549f50a322c1d7ef376122d3 Gerrit-Change-Number: 12324 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 19:07:44 +0000 Gerrit-HasComments: Yes
