Hello Brian McDevitt, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12347
to look at the new patch set (#2).
Change subject: KUDU-2411: Fix macOS relocation logic
......................................................................
KUDU-2411: Fix macOS relocation logic
This patch changes the macOS relocation logic in
relocate_binaries_for_mini_cluster.py by making the relocation logic
recursive.
This patch also includes a small repair script to repair existing macOS
archives. Pass any binaries or libraries that need "fixing" to the
repair script on the command line and it will attempt to fix their
library paths in-place.
Other changes in this patch:
* Use IOError instead of FileNotFoundError for Python 2.7 support
* Replace the use of "objdump -p" with "otool -l" because the former
doesn't work on Universal Mach-O binaries.
* Swallow the output from check_for_command() instead of printing the
output of "which" to stdout.
Change-Id: I0bb6ce15c705ada32579842f4ab6b1c5e0fca5fe
---
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
A build-support/mini-cluster/repair_macos_binary.py
2 files changed, 128 insertions(+), 41 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/47/12347/2
--
To view, visit http://gerrit.cloudera.org:8080/12347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0bb6ce15c705ada32579842f4ab6b1c5e0fca5fe
Gerrit-Change-Number: 12347
Gerrit-PatchSet: 2
Gerrit-Owner: Mike Percy <[email protected]>
Gerrit-Reviewer: Brian McDevitt <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
