Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12347 )
Change subject: KUDU-2411: Fix macOS relocation logic ...................................................................... KUDU-2411: Fix macOS relocation logic This patch changes the macOS relocation logic in relocate_binaries_for_mini_cluster.py by making the relocation routine recursive in order to collect and relocate transitive dependencies. Other changes in this patch: * Use IOError instead of FileNotFoundError for Python 2.7 support * Replace the use of "objdump -p" with "otool -l" because the former doesn't work on Universal Mach-O binaries. * Swallow the output from check_for_command() instead of printing the output of "which" to stdout. Change-Id: I0bb6ce15c705ada32579842f4ab6b1c5e0fca5fe Reviewed-on: http://gerrit.cloudera.org:8080/12347 Reviewed-by: Grant Henke <[email protected]> Tested-by: Grant Henke <[email protected]> --- M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py 1 file changed, 62 insertions(+), 42 deletions(-) Approvals: Grant Henke: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0bb6ce15c705ada32579842f4ab6b1c5e0fca5fe Gerrit-Change-Number: 12347 Gerrit-PatchSet: 5 Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]>
