Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12343/2//COMMIT_MSG@10 PS2, Line 10: useing using http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc File docker/README.adoc: http://gerrit.cloudera.org:8080/#/c/12343/2/docker/README.adoc@67 PS2, Line 67: kudu-tserver= Does there need to be a value after the equals sign? If it's up to the user, maybe indicate that with an argument surrounded by triangular brackets? http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml File docker/docker-compose.yml: PS2: Can you add a license header to this file? http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml@10 PS2, Line 10: - KUDU_MASTERS=kudu-master-1,kudu-master-2,kudu-master-3 This is converted into something useful by a script, right? Both for masters and tservers? -- To view, visit http://gerrit.cloudera.org:8080/12343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c Gerrit-Change-Number: 12343 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 03 Feb 2019 19:15:34 +0000 Gerrit-HasComments: Yes
