Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12343 )
Change subject: [docker] Add a docker-compose example ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc File docker/README.adoc: http://gerrit.cloudera.org:8080/#/c/12343/3/docker/README.adoc@101 PS3, Line 101: Kudu:base Nit: kudu:base (lower-case k). http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml File docker/docker-compose.yml: http://gerrit.cloudera.org:8080/#/c/12343/2/docker/docker-compose.yml@10 PS2, Line 10: # > That is something useful, those are valid hostnames from inside the contain Sorry, I meant "KUDU_MASTERS" (i.e. I couldn't remember where that environment variable gets used). Since then I reviewed the rest of your changes and saw it in the entrypoint script. -- To view, visit http://gerrit.cloudera.org:8080/12343 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie3ac3f9fca16b3bddf45ba24f6e6aa1efcee857c Gerrit-Change-Number: 12343 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 04 Feb 2019 04:30:30 +0000 Gerrit-HasComments: Yes
