Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12304 )
Change subject: [server] Add start_time in server description ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12304/2/src/kudu/common/wire_protocol.proto File src/kudu/common/wire_protocol.proto: http://gerrit.cloudera.org:8080/#/c/12304/2/src/kudu/common/wire_protocol.proto@96 PS2, Line 96: optional string start_time = 5; Do you feel strongly about storing this as a string instead of a "seconds since epoch" timestamp? As the protobuf is generally meant to be a machine-readable format, I think the "seconds since epoch" format will be easier to deal with, and we can always format it in UTC time or localtime when displaying it to a user. http://gerrit.cloudera.org:8080/#/c/12304/2/src/kudu/server/server_base.cc File src/kudu/server/server_base.cc: http://gerrit.cloudera.org:8080/#/c/12304/2/src/kudu/server/server_base.cc@683 PS2, Line 683: start_time_ = LocalTimeAsString(); using local time here is a bit confusing since servers eventaully may run in different time zones (eg if we deploy in a multi-AZ setup). Using an epoch time avoids that issue, and we can convert to localtime when we display it on the web page or CLI output -- To view, visit http://gerrit.cloudera.org:8080/12304 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I041467014499ad00c07398ad8f61c6d6ca1ceeca Gerrit-Change-Number: 12304 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 04 Feb 2019 19:22:16 +0000 Gerrit-HasComments: Yes
