Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12327 )
Change subject: KUDU-2677 Implement new gflag for backup history retention ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/12327/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12327/2//COMMIT_MSG@16 PS2, Line 16: users can just raise the : new flag, and ideally we will keep the semantics of "I want to be able : to back up to this point" in future releases, minimizing user-end : configuration changes. > The primary difference is that a new flag doesn't need to be stable. Additi Are those extra bits of color good enough for you Adar? I think their main points are captured in my current commit message. http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/integration-tests/tablet_history_gc-itest.cc File src/kudu/integration-tests/tablet_history_gc-itest.cc: http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/integration-tests/tablet_history_gc-itest.cc@119 PS2, Line 119: FLAGS_backup_max_age_sec = 0; > same here, maybe set to 0 in the constructor Done http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet.cc File src/kudu/tablet/tablet.cc: http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet.cc@150 PS2, Line 150: TAG_FLAG(backup_max_age_sec, experimental); > Probably shouldn't be experimental if anyone who wants to do an incremental Whoops, I meant evolving. http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet_history_gc-test.cc File src/kudu/tablet/tablet_history_gc-test.cc: http://gerrit.cloudera.org:8080/#/c/12327/2/src/kudu/tablet/tablet_history_gc-test.cc@158 PS2, Line 158: FLAGS_backup_max_age_sec = 1; > Consider setting this to 0 in the constructor for TabletHistoryGcTest? Done -- To view, visit http://gerrit.cloudera.org:8080/12327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c2c001c50f65e9acdfc032e8aa5efdacbd4d9e Gerrit-Change-Number: 12327 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Mon, 04 Feb 2019 21:09:02 +0000 Gerrit-HasComments: Yes
