Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12327 )
Change subject: KUDU-2677 Implement new gflag for backup history retention ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12327/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12327/3//COMMIT_MSG@9 PS3, Line 9: This patch implements a new flag, : --backup_max_age_sec, separate from --tablet_history_max_age_sec. Actual : retention will be maximum of these two flags What if the value set for the new value is still not enough? I don't have much context here, but maybe an alternative approach would be: instead GetTabletAncientHistoryMark() returning an earliest of timestamps among all scan operations at snapshot and the timestamp calculated from now for --tablet_history_max_age_sec setting? -- To view, visit http://gerrit.cloudera.org:8080/12327 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id6c2c001c50f65e9acdfc032e8aa5efdacbd4d9e Gerrit-Change-Number: 12327 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 05 Feb 2019 19:40:25 +0000 Gerrit-HasComments: Yes
