Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12373 )
Change subject: Rename DeadlineTracker to TimeoutTracker ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12373/1/src/kudu/scripts/assign-location.py File src/kudu/scripts/assign-location.py: http://gerrit.cloudera.org:8080/#/c/12373/1/src/kudu/scripts/assign-location.py@103 PS1, Line 103: timeout Are you sure this is in line with the semantic of this change? I thought the absolute point in time is called deadline, and relative interval calls timeout, no? Also, why to modify this file in the context of unrelated 'DeadlineTracker --> TimeoutTracker' renamings? -- To view, visit http://gerrit.cloudera.org:8080/12373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f465c925856390ecf4747e84bdd5a67c51c69eb Gerrit-Change-Number: 12373 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Comment-Date: Wed, 06 Feb 2019 05:11:01 +0000 Gerrit-HasComments: Yes
