Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12373 )
Change subject: Rename DeadlineTracker to TimeoutTracker ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12373/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/12373/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@294 PS3, Line 294: assert(this != parentRpc); nit: why is this removed, BTW? I though the top-level RPC would have null as its parent. Did it change, so the top-level RPC has parentRpc == this? -- To view, visit http://gerrit.cloudera.org:8080/12373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f465c925856390ecf4747e84bdd5a67c51c69eb Gerrit-Change-Number: 12373 Gerrit-PatchSet: 3 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 07 Feb 2019 22:24:59 +0000 Gerrit-HasComments: Yes
