Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12383 )
Change subject: [fs_manager-test] fix running the test on macOS ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12383/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12383/1//COMMIT_MSG@8 PS1, Line 8: > For posterity, would be good to add a snippet explaining why this was neces I put up this patch since some tests were failing :) Sure, I'll add the description. http://gerrit.cloudera.org:8080/#/c/12383/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/12383/1/src/kudu/fs/fs_manager-test.cc@426 PS1, Line 426: const auto block_manager_type = opts.block_manager_type; > This is only used once, so just use opts.block_manager_type down below? I don't think it's a good idea to use opts.block_manager_type below since at line 426 'opts' is invalidates by std::move(). -- To view, visit http://gerrit.cloudera.org:8080/12383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4 Gerrit-Change-Number: 12383 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Feb 2019 15:38:03 +0000 Gerrit-HasComments: Yes
