Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12383 )
Change subject: [fs_manager-test] fix running the test on macOS ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12383/1/src/kudu/fs/fs_manager-test.cc File src/kudu/fs/fs_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/12383/1/src/kudu/fs/fs_manager-test.cc@426 PS1, Line 426: const auto block_manager_type = opts.block_manager_type; > I don't think it's a good idea to use opts.block_manager_type below since a Ah indeed -- To view, visit http://gerrit.cloudera.org:8080/12383 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19a8c6f48435bf5424500c86283490c9fed408f4 Gerrit-Change-Number: 12383 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 06 Feb 2019 17:19:31 +0000 Gerrit-HasComments: Yes
