Hello Will Berkeley, Tidy Bot, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12416
to look at the new patch set (#3).
Change subject: KUDU-2645: schema: Validate that defaults are provided for
virtual columns
......................................................................
KUDU-2645: schema: Validate that defaults are provided for virtual columns
Virtual columns must not be nullable and must have read defaults.
Instead of crashing when we encounter violations of these requirements,
return a bad status code when mapping such a projection onto a tablet
schema.
TODO(KUDU-2692): Consider removing the requirement to specify a read
default on a virtual column by defining a built-in read default for each
virtual column type, such as a default of false for IS_DELETED.
Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
3 files changed, 13 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/16/12416/3
--
To view, visit http://gerrit.cloudera.org:8080/12416
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9144390f9ed02789a1ea161277b5f1567cfc2ffe
Gerrit-Change-Number: 12416
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
