Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12389 )
Change subject: WIP: add release notes for 1.9.0 ...................................................................... Patch Set 2: (21 comments) http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@51 PS1, Line 51: > Looking at this, it looks like it was always unusable by clients because th Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@52 PS1, Line 52: [[rn_1.9.0_new_features]] : == New featur > +1 Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@57 PS1, Line 57: rity of r > drop the parenthesis: masters Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@58 PS1, Line 58: s been update > run-time configuration flag Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@59 PS1, Line 59: e with the p > "locations". Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@60 PS1, Line 60: nistrati > the majority of replicas Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@62 PS1, Line 62: un Kudu on various : operating sys > we should link to the appropriate docs here, and maybe even remove some of Ack http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@65 PS1, Line 65: he Kudu Dock > subdirectory of the source repository? Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@66 PS1, Line 66: * People wanting to integrate with Kudu can now write Java unit tests that > +1 Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@72 PS1, Line 72: artifacts when starting up, the `kudu-binary` module must be added as a test : time dependency, along with the `kudu-test-utils` module in the project’s : Maven or Gradle build. The binary test artifact is stil > writing nit: "Table creation checks now consider" was hard to parse because Ah you're right, I reworded this incorrectly. http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@79 PS1, Line 79: * When creating a table, the master now enforces a restriction on the total > can we say what metric this is? Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@80 PS1, Line 80: number of replicas rather than the total number of partitions. If manually > is this documented anywhere in our troubleshooting docs or somesuch? Not at the moment, no. Do you think it's not worth mentioning if we don't also provide a guide for how to use/understand it? http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@81 PS1, Line 81: overriding `--max_create_tablets_per_ts`, the maximum size of a new table has : effectively been cut by a factor of its > Remove. Its value as a release note is pretty low, and it is easy to constr Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@83 PS1, Line 83: The compaction policy has been updated to > nit: I think this would be easier to understand if you said: "Scans which r Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@88 PS1, Line 88: much a replica needs to be compacted, as indicated by the average number of > This makes me raise my eyebrows a bit. It sounds like a good thing. If it's Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@91 PS1, Line 91: workload are now more CPU efficient. In some cases, scan performance of such > This isn't an incompatible change. It was done in a compatible way and the Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: ias > add link Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@98 PS1, Line 98: * Added the short “kudu” format alias to Spark. This enables using > yea I think in general linking the word 'here' is also bad style Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@107 PS1, Line 107: primary key (see KUDU-2477). > To avoid glitches and undefined behavior, the Kudu Python client will now d Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@108 PS1, Line 108: > typo: a crash Done http://gerrit.cloudera.org:8080/#/c/12389/1/docs/release_notes.adoc@167 PS1, Line 167: > typo Done -- To view, visit http://gerrit.cloudera.org:8080/12389 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.9.x Gerrit-MessageType: comment Gerrit-Change-Id: I733dfae39c06f15f7f55ae823678caf6ca433bfc Gerrit-Change-Number: 12389 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 09 Feb 2019 04:52:44 +0000 Gerrit-HasComments: Yes
