Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12446/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12446/1//COMMIT_MSG@10 PS1, Line 10: KuduPartialRow > ok, let's address that when it becomes an issue (if ever) It won't ever be an issue. We always had the const version in scan_batch.h http://gerrit.cloudera.org:8080/#/c/12446/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/12446/1/src/kudu/common/partial_row.h@365 PS1, Line 365: Status GetUnscaledDecimal(const Slice& col_name, int128_t* val) WARN_UNUSED_RESULT > That's a valid point, indeed. That's true that user is not in control of w It's a small one liner and I commented that it exists for backwards compat. I think if we decide to break ABI compat in the future we can drop it, but it's not a big deal. -- To view, visit http://gerrit.cloudera.org:8080/12446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9 Gerrit-Change-Number: 12446 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 12 Feb 2019 01:04:13 +0000 Gerrit-HasComments: Yes
