Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12446 )
Change subject: [client] Fix GetUnscaledDecimal backward compatiblity ...................................................................... Patch Set 1: (1 comment) > Patch Set 1: > > (1 comment) IWYU seems moody :( http://gerrit.cloudera.org:8080/#/c/12446/1/src/kudu/common/partial_row.h File src/kudu/common/partial_row.h: http://gerrit.cloudera.org:8080/#/c/12446/1/src/kudu/common/partial_row.h@365 PS1, Line 365: Status GetUnscaledDecimal(const Slice& col_name, int128_t* val) WARN_UNUSED_RESULT > I am not sure it matters since how you use it is the same and the outcome i Yeah fair enough. -- To view, visit http://gerrit.cloudera.org:8080/12446 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1bce3f6df6a09327a503f2793ed1317e147349c9 Gerrit-Change-Number: 12446 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 12 Feb 2019 02:15:37 +0000 Gerrit-HasComments: Yes
