Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12338 )
Change subject: KUDU-1868: Part 1: Add timer-based RPC timeouts ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@995 PS7, Line 995: newTimeout(timer, retryTask, sleepTime); Another option here is to provide a non-static newTimeout that passes this.timer into the static variant. http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@161 PS7, Line 161: new RpcTimeoutTask(), : timeoutMillis); Nit: indentation http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java: http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@115 PS7, Line 115: // The server will not respond for the lifetime of the test, so we expect the operation to time : // time out. Got an extra 'time' here. Also some of these lines may be too long; wrap? -- To view, visit http://gerrit.cloudera.org:8080/12338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d823b63ac0a41cc5e42b63a7c19e0ef777e1dea Gerrit-Change-Number: 12338 Gerrit-PatchSet: 7 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 17:33:03 +0000 Gerrit-HasComments: Yes
