Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12338 )
Change subject: KUDU-1868: Part 1: Add timer-based RPC timeouts ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2366 PS5, Line 2366: Preconditions.checkNotNull(timer); > Should passing a null timer be allowed? Done http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2366 PS5, Line 2366: Preconditions.checkNotNull(timer); > PreConditions.checkNotNull() seems reasonable here Done http://gerrit.cloudera.org:8080/#/c/12338/5/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java@2377 PS5, Line 2377: > It sounds like the only time this could happen you don't expect the user to We can't schedule a timeout on the timer, so we'd need to implement a FailedTimeout class and provide an instance (maybe a singleton). Does that seem worth it? I still can't say I buy that returning null from here to indicate failure it such a problem. http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java: http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/main/java/org/apache/kudu/client/KuduRpc.java@161 PS7, Line 161: this.timeoutTask = AsyncKuduClient.newTimeout(timer, : new RpcTimeout > Nit: indentation Done http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java: http://gerrit.cloudera.org:8080/#/c/12338/7/java/kudu-client/src/test/java/org/apache/kudu/client/TestTimeouts.java@115 PS7, Line 115: : // The serve > Got an extra 'time' here. Also some of these lines may be too long; wrap? Done -- To view, visit http://gerrit.cloudera.org:8080/12338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d823b63ac0a41cc5e42b63a7c19e0ef777e1dea Gerrit-Change-Number: 12338 Gerrit-PatchSet: 8 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 19:14:58 +0000 Gerrit-HasComments: Yes
