Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356 PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=all") > Are you sure this is the right conversion? Won't this mean that ASAN errors I would expect it to affect only the sanitized cases. However, since we explicitly ask to sanitize UB and integer-related issue, probably -fno-sanitize-recover=undefined,integer is a better choice here. Done. -- To view, visit http://gerrit.cloudera.org:8080/12459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7 Gerrit-Change-Number: 12459 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 00:43:34 +0000 Gerrit-HasComments: Yes
