Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12459 )
Change subject: [CMakeLists] get rid of warnings in ASAN builds ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt File CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/12459/1/CMakeLists.txt@356 PS1, Line 356: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-sanitize-recover=undefined,integer") > I would expect it to affect only the sanitized cases. The issue is that we typically build with both -DKUDU_USE_ASAN=1 and -DKUDU_USE_UBSAN=1 (that's how our 'ASAN' build type works), so we'll end up running multiple sanitizers simultaneously. In that case, 'all' will affect more than just UB and integers. -- To view, visit http://gerrit.cloudera.org:8080/12459 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a5877ed1743387881ab1d31f42519a361b64ea7 Gerrit-Change-Number: 12459 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 13 Feb 2019 01:36:40 +0000 Gerrit-HasComments: Yes
