Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12486 )
Change subject: [tests] fix running tests under super-user ...................................................................... Patch Set 2: (2 comments) FWIW, I don't think this is goofy; it lowers the barrier to running tests (if for some reason one's dev environment uses root). http://gerrit.cloudera.org:8080/#/c/12486/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12486/2//COMMIT_MSG@9 PS2, Line 9: That's Nit: just 'That' http://gerrit.cloudera.org:8080/#/c/12486/2/src/kudu/rpc/negotiation-test.cc File src/kudu/rpc/negotiation-test.cc: http://gerrit.cloudera.org:8080/#/c/12486/2/src/kudu/rpc/negotiation-test.cc@1169 PS2, Line 1169: if (geteuid() == 0) { : // The super-user can acess the 'inaccessible' keytab file anyway. : ASSERT_TRUE(s.ok()) << s.ToString(); : } else { : ASSERT_FALSE(s.ok()) << s.ToString(); Maybe cleaner as a ternary? ASSERT_TRUE(geteuid() == 0 ? s.ok() : !s.ok()) << s.ToString(); Might also apply to the other test fixes. -- To view, visit http://gerrit.cloudera.org:8080/12486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05bf220ee8000209a3e36faa9f21fd43ab8bdc9f Gerrit-Change-Number: 12486 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Feb 2019 22:14:03 +0000 Gerrit-HasComments: Yes
