Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12486 )
Change subject: [tests] fix running tests under the super-user ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12486/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12486/2//COMMIT_MSG@9 PS2, Line 9: Recent > Nit: just 'That' Done http://gerrit.cloudera.org:8080/#/c/12486/2/src/kudu/rpc/negotiation-test.cc File src/kudu/rpc/negotiation-test.cc: http://gerrit.cloudera.org:8080/#/c/12486/2/src/kudu/rpc/negotiation-test.cc@1169 PS2, Line 1169: if (geteuid() == 0) { : // The super-user can acess the 'inaccessible' keytab file anyway. : ASSERT_TRUE(s.ok()) << s.ToString(); : } else { : ASSERT_FALSE(s.ok()) << s.ToString(); > Maybe cleaner as a ternary? Yep, that makes sense when there is only one related assertion, but in this case there is also ASSERT_STR_MATCHES(s.ToString(), "error accessing keytab: Permission denied") for KRB5_VERSION_LE_1_10. I'll try to apply this in other places, though. -- To view, visit http://gerrit.cloudera.org:8080/12486 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05bf220ee8000209a3e36faa9f21fd43ab8bdc9f Gerrit-Change-Number: 12486 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 15 Feb 2019 00:54:47 +0000 Gerrit-HasComments: Yes
