Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12488 )
Change subject: KUDU-2701 Fix compaction loop due to using wrong rowset size ...................................................................... Patch Set 1: (1 comment) Have you tried putting this patch on the cluster you saw KUDU-2701 on? http://gerrit.cloudera.org:8080/#/c/12488/1/src/kudu/tablet/rowset_info.cc File src/kudu/tablet/rowset_info.cc: http://gerrit.cloudera.org:8080/#/c/12488/1/src/kudu/tablet/rowset_info.cc@474 PS1, Line 474: cdf_rs.value_ = ComputeRowsetValue(cdf_rs.width(), cdf_rs.extra_->size_bytes); Perhaps make a note of KUDU-2701 that the distinction between size_bytes and base_and_redos_size_mb_ is intentional and very important? Maybe a summarizing comment? -- To view, visit http://gerrit.cloudera.org:8080/12488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b7ff6333137aaf1e98ef4849691dd08e24e007 Gerrit-Change-Number: 12488 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 14 Feb 2019 23:53:59 +0000 Gerrit-HasComments: Yes
