Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12488 )
Change subject: KUDU-2701 Fix compaction loop due to using wrong rowset size ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12488/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12488/1//COMMIT_MSG@14 PS1, Line 14: the size of the whole rowset should be used > Can you be more explicit about which missing pieces are critical? Is it the It's actually the blooms: table id | tablet id | rowset id | block type | size ----------------------------------+----------------------------------+-----------+-----------------+-------- 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | c0 (key) | 8.56M 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | c1 (int_val) | 8.10M 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | c2 (string_val) | 42.6K 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | REDO | 0B 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | UNDO | 0B 72e0935bd65a488ca45ab81f99d84dce | 39aba63834b441e0b26d7aa5949f92ae | 2877 | BLOOM | 15.38M Sorry if that prints like crap. http://gerrit.cloudera.org:8080/#/c/12488/1//COMMIT_MSG@15 PS1, Line 15: values > Nit: this is used as a verb, right? Took a while to parse the sentence; may Done -- To view, visit http://gerrit.cloudera.org:8080/12488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b7ff6333137aaf1e98ef4849691dd08e24e007 Gerrit-Change-Number: 12488 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 23:43:31 +0000 Gerrit-HasComments: Yes
