Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/12489 )
Change subject: Enable --rowset_metadata_store_keys by default ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/12489/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12489/1//COMMIT_MSG@13 PS1, Line 13: off > on Done http://gerrit.cloudera.org:8080/#/c/12489/1//COMMIT_MSG@12 PS1, Line 12: I think we : should try turning this flag off (at the beginning of the 1.10 release : cycle) to see if it would be a good idea to have it on by default > If we do end up deciding to keep this enabled, we may also want to consider Done http://gerrit.cloudera.org:8080/#/c/12489/1//COMMIT_MSG@21 PS1, Line 21: Expected cost: > Won't this also defer more lazy initialization work (i.e. initializing the Done http://gerrit.cloudera.org:8080/#/c/12489/1//COMMIT_MSG@22 PS1, Line 22: metdata > metadata I usually type meatdata :) -- To view, visit http://gerrit.cloudera.org:8080/12489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4ac4b58845666cd10102fb125fc787c637e473 Gerrit-Change-Number: 12489 Gerrit-PatchSet: 1 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 15 Feb 2019 18:09:08 +0000 Gerrit-HasComments: Yes
