Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12489 )
Change subject: Enable --rowset_metadata_store_keys by default ...................................................................... Patch Set 2: Code-Review-1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12489/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12489/2//COMMIT_MSG@28 PS2, Line 28: differently. I'm nervous that although it's the same O(n), the PK can be quite large -- up to 16kb in our default config. So, if you have 10,000 rowsets (on the high end but we do see this especailly with bugs like KUDU-1400) you're potentially adding 10,000*16kb*2 = 320MB to the tablet metadata. That would then be too large to actually support tablet copies, and run into protobuf deserialization limits, etc. That was my original argument for introducing this off-by-default and I think I'm still afraid it would be a destabilizing change until we switch out the way we store tablet metadata or have some tighter bound on rowset count. -- To view, visit http://gerrit.cloudera.org:8080/12489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2c4ac4b58845666cd10102fb125fc787c637e473 Gerrit-Change-Number: 12489 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 15 Feb 2019 19:29:47 +0000 Gerrit-HasComments: Yes
