Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12517
to look at the new patch set (#2).
Change subject: [tools] Support starting master and tablet server via the kudu
binary
......................................................................
[tools] Support starting master and tablet server via the kudu binary
Adds commands to the kudu tools to run the master
and tablet server:
- `kudu master start ...`
- `kudu tserver start …`
This means we can ship a single binary in the kudu
docker image or potentially the kudu-binary jar
reducing the size by appoximately 66%. Though
follow up changes may be needed in the kudu-binary
case.
The behavior is the same as running the kudu-master
and kudu-tserver binaries except that by default we log
to stderr. We log to stderr because it maintains the
same logging behavior as the rest of the tools.
Additionally, by default the log_filename would be `kudu`
to match the binary which could lead to confusing logfile
naming issues.
This patch also contains a few releated fixes for default
flags ensuring that they can be overwritten when
neccessary. These changes also ensure flags are not
incorrectly reported as non-default.
Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e
---
M src/kudu/master/master_main.cc
M src/kudu/tools/tool_action_master.cc
M src/kudu/tools/tool_action_tserver.cc
M src/kudu/tools/tool_main.cc
M src/kudu/tserver/tablet_server.h
M src/kudu/tserver/tablet_server_main.cc
M src/kudu/util/flags.cc
M src/kudu/util/flags.h
8 files changed, 215 insertions(+), 19 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/17/12517/2
--
To view, visit http://gerrit.cloudera.org:8080/12517
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e
Gerrit-Change-Number: 12517
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
