Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12517 )
Change subject: [tools] Support starting master and tablet server via the kudu binary ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/12517/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12517/3//COMMIT_MSG@13 PS3, Line 13: : This means we can ship a single binary in the kudu : docker image or potentially the kudu-binary jar : reducing the size by appoximately 66%. Does this also inflate the size of the `kudu` binary? If so, by how much? http://gerrit.cloudera.org:8080/#/c/12517/3//COMMIT_MSG@22 PS3, Line 22: be by http://gerrit.cloudera.org:8080/#/c/12517/3//COMMIT_MSG@25 PS3, Line 25: log_filename How does this work wrt the log_dir flag? Does it just allow users to specify the prefix? If so, maybe name it log_file_prefix or something? Particularly since the logs will be suffixed by the date and the 'diagnostics' tag. http://gerrit.cloudera.org:8080/#/c/12517/3//COMMIT_MSG@29 PS3, Line 29: releated related http://gerrit.cloudera.org:8080/#/c/12517/2/src/kudu/util/flags.h File src/kudu/util/flags.h: http://gerrit.cloudera.org:8080/#/c/12517/2/src/kudu/util/flags.h@75 PS2, Line 75: // Get all the flags different their defaults. The output is a nicely : // formatted string with --flag=value pairs per line. Redact any flags that : // are tagged as sensitive, if redaction is enabled. nit: it wasn't clear to me how this was different from above; perhaps rephrase like, "Like above, but infers the default values of flags"? -- To view, visit http://gerrit.cloudera.org:8080/12517 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3717cbac930b3506a76f7a51388c64afbcbb480e Gerrit-Change-Number: 12517 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 00:27:26 +0000 Gerrit-HasComments: Yes
