Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12500 )
Change subject: [sentry] add privilege scope validation to SentryAuthzProvider ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12500/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12500/1//COMMIT_MSG@29 PS1, Line 29: 'server == server1 && (db == default || db == NULL) && (table == a || table == NULL)'. nit: this was weird to read at first. Perhaps: server == "server1" && (db == "default" || db == NULL) && (table == "a" || table == NULL) Same below. http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG@29 PS2, Line 29: 'server == server1 && (db == default || db == NULL) && (table == a || table == NULL)'. To clarify, this is being evaluated on the Sentry server? What is this filtering statement being run on? http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG@33 PS2, Line 33: sentry API will return anything that matches Understanding this requires an understanding of the Sentry API, what it returns, to whom, and how the returned stuff is used. Could you include these details in this commit message? It's pretty difficult for me to understand. -- To view, visit http://gerrit.cloudera.org:8080/12500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89437a04a4fa18e501d21c3abf5d66a2d22ce58a Gerrit-Change-Number: 12500 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 05:38:06 +0000 Gerrit-HasComments: Yes
