Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12500 )
Change subject: [sentry] add privilege scope validation to SentryAuthzProvider ...................................................................... Patch Set 2: (3 comments) Like Andrew and Alexey, I'm also kind of perplexed by this, though it's probably because I don't know enough about Sentry. It's unclear from the commit message why this is a problem that needs to be solved within Kudu and not within Sentry. http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG@12 PS2, Line 12: a privilege implies another when, Nit: if all of these conditions must be met, consider rephrasing as: a privilege implies another when: 1. ..., and 2. ..., and 3. ... That makes it more clear that ALL conditions are required rather than ANY condition. http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG@24 PS2, Line 24: with Nit: drop 'with' http://gerrit.cloudera.org:8080/#/c/12500/2//COMMIT_MSG@39 PS2, Line 39: privilge privilege -- To view, visit http://gerrit.cloudera.org:8080/12500 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89437a04a4fa18e501d21c3abf5d66a2d22ce58a Gerrit-Change-Number: 12500 Gerrit-PatchSet: 2 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 23:40:03 +0000 Gerrit-HasComments: Yes
