Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12462 )
Change subject: KUDU-2690: don't roll log schema on failed alter ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/12462/2/src/kudu/tablet/transactions/alter_schema_transaction.cc File src/kudu/tablet/transactions/alter_schema_transaction.cc: http://gerrit.cloudera.org:8080/#/c/12462/2/src/kudu/tablet/transactions/alter_schema_transaction.cc@153 PS2, Line 153: } : : // The schema lock was acquired by Tablet::CreatePreparedAlterSchem > I'm wondering, if this is skipped, whether a client waiting on an ongoing A In this case, AlterSchema the function succeeded, but if the logical operation didn't succeed, there would be no change to metadata's schema_version_ (see tablet/tablet.cc::AlterSchema()). I can add a comment to that effect. Given that's the case, do you still think it's worth marking dirty? I'm hesitant because KUDU-2681 means that over-reporting can be costly and make things painful to debug; and in the case that that report has no real changes, I'd rather not report anything. -- To view, visit http://gerrit.cloudera.org:8080/12462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id761851741297e29a4666bec0c34fc4f7285f715 Gerrit-Change-Number: 12462 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 19 Feb 2019 20:55:26 +0000 Gerrit-HasComments: Yes
