Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12462 )
Change subject: KUDU-2690: don't roll log schema on failed alter ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/12462/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12462/6//COMMIT_MSG@25 PS6, Line 25: use > uses Done http://gerrit.cloudera.org:8080/#/c/12462/6/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: http://gerrit.cloudera.org:8080/#/c/12462/6/src/kudu/tablet/tablet_bootstrap.cc@1458 PS6, Line 1458: // 3. The commit message contains a 'result', which should only happen if the : // alter resulted in a failure. Exit out without attempting the alter. > AlterSchemas aren't very common, so maybe we should follow the convention o Clarifying the behavior of writes: - if there is an error, record it - if not, record the memstore that the operation affected AFAICT this is done out of necessity; I don't think there is a need to do so for alters. >do we do the same for ChangeConfig? No, the commit message is untouched during replay for ChangeConfig and NoOps, and AFAICT they don't have any results. http://gerrit.cloudera.org:8080/#/c/12462/6/src/kudu/tablet/tablet_replica-test.cc File src/kudu/tablet/tablet_replica-test.cc: http://gerrit.cloudera.org:8080/#/c/12462/6/src/kudu/tablet/tablet_replica-test.cc@137 PS6, Line 137: scoped_refptr<ConsensusMetadataManager> cmeta_manager( > Could we store this so that your new test needn't recreate it as part of th Done -- To view, visit http://gerrit.cloudera.org:8080/12462 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id761851741297e29a4666bec0c34fc4f7285f715 Gerrit-Change-Number: 12462 Gerrit-PatchSet: 6 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 00:17:50 +0000 Gerrit-HasComments: Yes
