Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12526 )
Change subject: [minicluster] Fix building with python 2.6 ...................................................................... Patch Set 1: Code-Review+1 (2 comments) LGTM, just want to make sure I understand the change http://gerrit.cloudera.org:8080/#/c/12526/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12526/1//COMMIT_MSG@14 PS1, Line 14: Because I used Docker to test this, the related Docker Is the chrpath change related to the python change? Or is it just a change that happened to be necessary for centos6? (and ubuntu, it seems?) http://gerrit.cloudera.org:8080/#/c/12526/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py File build-support/mini-cluster/relocate_binaries_for_mini_cluster.py: http://gerrit.cloudera.org:8080/#/c/12526/1/build-support/mini-cluster/relocate_binaries_for_mini_cluster.py@119 PS1, Line 119: check_output I'm confused by this change; I thought you could only use this syntax if you did: from subprocess import check_output or somesuch -- To view, visit http://gerrit.cloudera.org:8080/12526 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id9e7ce9a1fd7ac813866678d6ec804fdf91ea729 Gerrit-Change-Number: 12526 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Feb 2019 21:58:52 +0000 Gerrit-HasComments: Yes
